kubernetes-sigs/prometheus-adapter
1
0
Fork 1
mirror of https://github.com/kubernetes-sigs/prometheus-adapter.git synced 2026-04-06 09:47:54 +00:00
Code Issues Projects Releases Packages Activity Actions

Update walkthrough.md

Browse source 
selecting label with `metricLabelSelector` and not `selector`
cf. 0ca2b1909c/pkg/apiserver/installer/conversion.go (L36)
This commit is contained in:
Rene Luria 2021-09-15 14:51:48 +02:00 • committed by GitHub
parent 12309c9d1d
commit 79ef58e11a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/walkthrough.md
View file

@ -175,7 +175,7 @@ spec:
If you try creating that now (and take a look at your controller-manager If you try creating that now (and take a look at your controller-manager
logs), you'll see that the that the HorizontalPodAutoscaler controller is logs), you'll see that the that the HorizontalPodAutoscaler controller is
attempting to fetch metrics from attempting to fetch metrics from
`/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?selector=app%3Dsample-app`, `/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?metricLabelSelector=app%3Dsample-app`,
but right now, nothing's serving that API. but right now, nothing's serving that API.
Before you can autoscale your application, you'll need to make sure that Before you can autoscale your application, you'll need to make sure that
@ -293,7 +293,7 @@ sends a raw GET request to the Kubernetes API server, automatically
injecting auth information: injecting auth information:
```shell ```shell
$ kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?selector=app%3Dsample-app" $ kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?metricLabelSelector=app%3Dsample-app"
``` ```
Because of the adapter's configuration, the cumulative metric Because of the adapter's configuration, the cumulative metric