From 79ef58e11ac0e2d9ee0eb7bb99b90fd2470a97f2 Mon Sep 17 00:00:00 2001 From: Rene Luria Date: Wed, 15 Sep 2021 14:51:48 +0200 Subject: [PATCH] Update walkthrough.md selecting label with `metricLabelSelector` and not `selector` cf. https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/0ca2b1909cdc45259654a4e06cac40f98fa1bcb0/pkg/apiserver/installer/conversion.go#L36 --- docs/walkthrough.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/walkthrough.md b/docs/walkthrough.md index 67074436..90c5fdcf 100644 --- a/docs/walkthrough.md +++ b/docs/walkthrough.md @@ -175,7 +175,7 @@ spec: If you try creating that now (and take a look at your controller-manager logs), you'll see that the that the HorizontalPodAutoscaler controller is attempting to fetch metrics from -`/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?selector=app%3Dsample-app`, +`/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?metricLabelSelector=app%3Dsample-app`, but right now, nothing's serving that API. Before you can autoscale your application, you'll need to make sure that @@ -293,7 +293,7 @@ sends a raw GET request to the Kubernetes API server, automatically injecting auth information: ```shell -$ kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?selector=app%3Dsample-app" +$ kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/http_requests?metricLabelSelector=app%3Dsample-app" ``` Because of the adapter's configuration, the cumulative metric