Compare commits

...

4 commits

Author SHA1 Message Date
Kubernetes Prow Robot
13a25e2a39
Merge pull request #460 from dgrisonnet/release-0.9.1
*: cut release-0.9.1
2021-10-14 02:03:19 -07:00
Damien Grisonnet
46c87b48ab *: cut release-0.9.1
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
2021-10-13 18:35:36 +02:00
Kubernetes Prow Robot
ad6a79b62a
Merge pull request #459 from leoskyrocker/release-0.9
Fix external metrics provider not respecting metrics-max-age
2021-10-13 09:25:49 -07:00
Leo Lei
2187385ed2 Fix external metrics provider not respecting metrics-max-age 2021-10-13 09:36:36 +08:00
3 changed files with 4 additions and 4 deletions

View file

@ -1 +1 @@
0.8.4
0.9.1

View file

@ -211,7 +211,7 @@ func (cmd *PrometheusAdapter) makeExternalProvider(promClient prom.Client, stopC
}
// construct the provider and start it
emProvider, runner := extprov.NewExternalPrometheusProvider(promClient, namers, cmd.MetricsRelistInterval)
emProvider, runner := extprov.NewExternalPrometheusProvider(promClient, namers, cmd.MetricsRelistInterval, cmd.MetricsMaxAge)
runner.RunUntil(stopCh)
return emProvider, nil

View file

@ -77,9 +77,9 @@ func (p *externalPrometheusProvider) selectGroupResource(namespace string) schem
}
// NewExternalPrometheusProvider creates an ExternalMetricsProvider capable of responding to Kubernetes requests for external metric data
func NewExternalPrometheusProvider(promClient prom.Client, namers []naming.MetricNamer, updateInterval time.Duration) (provider.ExternalMetricsProvider, Runnable) {
func NewExternalPrometheusProvider(promClient prom.Client, namers []naming.MetricNamer, updateInterval time.Duration, maxAge time.Duration) (provider.ExternalMetricsProvider, Runnable) {
metricConverter := NewMetricConverter()
basicLister := NewBasicMetricLister(promClient, namers, updateInterval)
basicLister := NewBasicMetricLister(promClient, namers, maxAge)
periodicLister, _ := NewPeriodicMetricLister(basicLister, updateInterval)
seriesRegistry := NewExternalSeriesRegistry(periodicLister)
return &externalPrometheusProvider{