From fdff124fb1afd2b415602efd16b8d78f2776b220 Mon Sep 17 00:00:00 2001 From: cerberus20 <119214363+cerberus20@users.noreply.github.com> Date: Mon, 6 May 2024 09:19:59 +0530 Subject: [PATCH] Update comments --- pkg/client/metrics/metrics.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/client/metrics/metrics.go b/pkg/client/metrics/metrics.go index 523b748a..3439e1ab 100644 --- a/pkg/client/metrics/metrics.go +++ b/pkg/client/metrics/metrics.go @@ -46,7 +46,7 @@ var ( []string{"path", "server"}, ) - // define a counter for API errors for various ErrorTypes + // define a counter for api requests apiRequestsTotal = metrics.NewCounterVec( &metrics.CounterOpts{ Namespace: "prometheus_adapter", @@ -94,10 +94,8 @@ func (c *instrumentedGenericClient) Do(ctx context.Context, verb, endpoint strin endTime := time.Now() if err != nil { if apiErr, wasAPIErr := err.(*client.Error); wasAPIErr { - // measure API errors apiRequestsTotal.With(prometheus.Labels{"code": string(apiErr.Type), "path": endpoint, "server": c.serverName}).Inc() } else { - // increment a generic error code counter apiRequestsTotal.With(prometheus.Labels{"code": "generic", "path": endpoint, "server": c.serverName}).Inc() } return