kubernetes-sigs/prometheus-adapter
1
0
Fork 1
mirror of https://github.com/kubernetes-sigs/prometheus-adapter.git synced 2026-04-07 22:25:03 +00:00
Code Issues Projects Releases Packages Activity Actions

Intermediate progress.

Browse source 
Working through some of the result conversions.
I want to use this code in a harness project to exercise some of it, but there are some versioning issues around my modified code vs. the current version of the real project. The easiest way to work around them at the moment is to push this.
This commit is contained in:
Tony Compton 2018-06-29 09:46:26 -04:00
parent a69a5cbbcc
commit d90012439c
6 changed files with 68 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

37
pkg/custom-provider/metric-converter/scalar_converter.go
View file

@ -19,7 +19,7 @@ func NewScalarConverter() MetricConverter {
return &scalarConverter{}
}
func (c *scalarConverter) Convert(queryResult prom.QueryResult) (*external_metrics.ExternalMetricValueList, error) {
func (c *scalarConverter) Convert(metadata QueryMetadata, queryResult prom.QueryResult) (*external_metrics.ExternalMetricValueList, error) {
if queryResult.Type != model.ValScalar {
return nil, errors.New("scalarConverter can only convert scalar query results")
}
@ -30,37 +30,26 @@ func (c *scalarConverter) Convert(queryResult prom.QueryResult) (*external_metri
return nil, errors.New("the provided input did not contain scalar query results")
}
return c.convert(toConvert)
return c.convert(metadata, toConvert)
}
func (c *scalarConverter) convert(input *model.Scalar) (*external_metrics.ExternalMetricValueList, error) {
tempWindow := int64(0)
func (c *scalarConverter) convert(metadata QueryMetadata, input *model.Scalar) (*external_metrics.ExternalMetricValueList, error) {
result := external_metrics.ExternalMetricValueList{
//TODO: Where should all of these values come from?
TypeMeta: metav1.TypeMeta{
Kind: "?",
APIVersion: "?",
},
ListMeta: metav1.ListMeta{
SelfLink: "?",
ResourceVersion: "?",
Continue: "?",
},
//Using prometheusProvider.metricsFor(...) as an example,
//it seems that I don't need to provide values for
//TypeMeta and ListMeta.
//TODO: Get some confirmation on this.
Items: []external_metrics.ExternalMetricValue{
external_metrics.ExternalMetricValue{
TypeMeta: metav1.TypeMeta{
Kind: "?",
APIVersion: "?",
},
//TODO: Carry forward the metric name so we can set it here.
MetricName: "?",
MetricName: metadata.MetricName,
Timestamp: metav1.Time{
input.Timestamp.Time(),
},
//TODO: Carry forward some information about our configuration so we can provide it here.
WindowSeconds: &tempWindow,
//TODO: Jump through the necessary hoops to convert our number into the proper type.
Value: resource.Quantity{},
WindowSeconds: &metadata.WindowInSeconds,
//TODO: I'm not so sure about this type/conversions.
//Is there a meaningful loss of precision here?
//Does K8S only deal win integer metrics?
Value: *resource.NewQuantity(int64(input.Value), resource.DecimalSI),
},
},
}