From cc1016f7f0407eb8fb3b5db9c8c4c2b7db2df2fa Mon Sep 17 00:00:00 2001 From: stoyansbg Date: Thu, 16 Feb 2023 15:20:33 +0200 Subject: [PATCH] selector -> labelSelector Reference: https://github.com/kubernetes/design-proposals-archive/blob/main/instrumentation/custom-metrics-api.md#relationship-to-hpa-v2 --- docs/walkthrough.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/walkthrough.md b/docs/walkthrough.md index 64ffa94c..d6b01eda 100644 --- a/docs/walkthrough.md +++ b/docs/walkthrough.md @@ -179,7 +179,7 @@ spec: If you try creating that now (and take a look at your controller-manager logs), you'll see that the that the HorizontalPodAutoscaler controller is attempting to fetch metrics from -`/apis/custom.metrics.k8s.io/v1beta2/namespaces/default/pods/*/http_requests?selector=app%3Dsample-app`, +`/apis/custom.metrics.k8s.io/v1beta2/namespaces/default/pods/*/http_requests?labelSelector=app%3Dsample-app`, but right now, nothing's serving that API. Before you can autoscale your application, you'll need to make sure that @@ -361,7 +361,7 @@ sends a raw GET request to the Kubernetes API server, automatically injecting auth information: ```shell -$ kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta2/namespaces/default/pods/*/http_requests?selector=app%3Dsample-app" +$ kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta2/namespaces/default/pods/*/http_requests?labelSelector=app%3Dsample-app" ``` Because of the adapter's configuration, the cumulative metric