kubernetes-sigs/prometheus-adapter
1
0
Fork 1
mirror of https://github.com/kubernetes-sigs/prometheus-adapter.git synced 2026-04-06 01:38:10 +00:00
Code Issues Projects Releases Packages Activity Actions

Improve error handling in adapter.go

Browse source
This commit is contained in:
Matthias Loibl 2018-12-03 17:18:53 +01:00
parent 5d837a29dd
commit bef034e699
No known key found for this signature in database
GPG key ID: B1C7DF661ABB2C1A
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
cmd/adapter/adapter.go
View file

@ -22,7 +22,6 @@ import (
"flag" "flag"
"fmt" "fmt"
"io/ioutil" "io/ioutil"
"log"
"net/http" "net/http"
"net/url" "net/url"
"os" "os"
@ -200,7 +199,9 @@ func main() {
cmd.Name = "prometheus-metrics-adapter" cmd.Name = "prometheus-metrics-adapter"
cmd.addFlags() cmd.addFlags()
cmd.Flags().AddGoFlagSet(flag.CommandLine) // make sure we get the glog flags cmd.Flags().AddGoFlagSet(flag.CommandLine) // make sure we get the glog flags
cmd.Flags().Parse(os.Args) if err := cmd.Flags().Parse(os.Args); err != nil {
glog.Fatalf("unable to parse flags: %v", err)
}
// make the prometheus client // make the prometheus client
promClient, err := cmd.makePromClient() promClient, err := cmd.makePromClient()
@ -280,7 +281,7 @@ func makePrometheusCAClient(caFilename string) (*http.Client, error) {
return nil, fmt.Errorf("failed to read prometheus-ca-file: %v", err) return nil, fmt.Errorf("failed to read prometheus-ca-file: %v", err)
} }
if !pool.AppendCertsFromPEM(data) { if !pool.AppendCertsFromPEM(data) {
log.Printf("warning: no certs found in prometheus-ca-file") return nil, fmt.Errorf("no certs found in prometheus-ca-file")
} }
return &http.Client{ return &http.Client{