Cleaning up.

* Wiped out a ton of warnings about comments.
* Created consts for `MetricType` values.
* `externalInfoMap` can now track multiple series with the same name/namespace and different labels.
* `namespace` parameter of external metrics queries is now respected (albeit very rudimentarily)
* Metric converter values for external metrics are now converted the same way as for custom metrics (probably still some opportunity for consolidation).
* Lots of TODOs actually done.
* Deleted a lot of commented out code.

pkg/custom-provider/metric-converter/matrix_converter.go

@@ -32,6 +32,6 @@ func (c *matrixConverter) Convert(queryResult prom.QueryResult) (*external_metri
 }
 
 func (c *matrixConverter) convert(result *model.Matrix) (*external_metrics.ExternalMetricValueList, error) {
-	//TODO: Implementation.
+	//TODO: AC - Implementation.
 	return nil, errors.New("converting Matrix results is not yet supported")
 }

pkg/custom-provider/metric-converter/sample_converter.go

@@ -30,14 +30,10 @@ func (c *sampleConverter) Convert(sample *model.Sample) (*external_metrics.Exter
 		Timestamp: metav1.Time{
 			sample.Timestamp.Time(),
 		},
-		//TODO: I'm not so sure about this type/conversions.
-		//This can't possibly be the right way to convert this.
-		//Also, does K8S only deal win integer metrics?
-		Value:        *resource.NewQuantity(int64(float64(sample.Value)), resource.DecimalSI),
+		Value:        *resource.NewMilliQuantity(int64(sample.Value*1000.0), resource.DecimalSI),
 		MetricLabels: labels,
 	}
 
-	//TODO: Actual errors?
 	return &singleMetric, nil
 }
 

pkg/custom-provider/metric-converter/scalar_converter.go

@@ -35,18 +35,11 @@ func (c *scalarConverter) Convert(queryResult prom.QueryResult) (*external_metri
 
 func (c *scalarConverter) convert(input *model.Scalar) (*external_metrics.ExternalMetricValueList, error) {
 	result := external_metrics.ExternalMetricValueList{
-		//Using prometheusProvider.metricsFor(...) as an example,
-		//it seems that I don't need to provide values for
-		//TypeMeta and ListMeta.
-		//TODO: Get some confirmation on this.
 		Items: []external_metrics.ExternalMetricValue{
 			{
 				Timestamp: metav1.Time{
 					input.Timestamp.Time(),
 				},
-				//TODO: I'm not so sure about this type/conversions.
-				//Is there a meaningful loss of precision here?
-				//Does K8S only deal win integer metrics?
 				Value: *resource.NewMilliQuantity(int64(input.Value*1000.0), resource.DecimalSI),
 			},
 		},

pkg/custom-provider/metric-converter/vector_converter.go

@@ -2,6 +2,7 @@ package provider
 
 import (
 	"errors"
+	"fmt"
 
 	prom "github.com/directxman12/k8s-prometheus-adapter/pkg/client"
 	"github.com/prometheus/common/model"
@@ -46,8 +47,13 @@ func (c *vectorConverter) convert(result model.Vector) (*external_metrics.Extern
 	}
 
 	for _, val := range result {
-		//TODO: Care about potential errors here.
-		singleMetric, _ := c.SampleConverter.Convert(val)
+
+		singleMetric, err := c.SampleConverter.Convert(val)
+
+		if err != nil {
+			return nil, fmt.Errorf("unable to convert vector: %v", err)
+		}
+
 		items = append(items, *singleMetric)
 	}