From 9d7157f7ccc0a47ee7a15c36ede16725f283d5e0 Mon Sep 17 00:00:00 2001 From: Solly Ross Date: Mon, 20 Aug 2018 16:53:51 -0400 Subject: [PATCH] Reduce metric namer label-GVR logspam It's fairly common to have a label pattern that matches lots of irrelevant labels, so this makes the "error" about being unable to normalize/resolve a label to a GVR a V(9) info log, instead of an error log. --- pkg/custom-provider/metric_namer.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/custom-provider/metric_namer.go b/pkg/custom-provider/metric_namer.go index 7de4f69d..0c17090b 100644 --- a/pkg/custom-provider/metric_namer.go +++ b/pkg/custom-provider/metric_namer.go @@ -275,7 +275,8 @@ func (n *metricNamer) ResourcesForSeries(series prom.Series) ([]schema.GroupReso if groupRes, ok = n.labelResExtractor.GroupResourceForLabel(lbl); ok { info, _, err := provider.CustomMetricInfo{GroupResource: groupRes}.Normalized(n.mapper) if err != nil { - glog.Errorf("unable to normalize group-resource %s from label %q, skipping: %v", groupRes.String(), lbl, err) + // this is likely to show up for a lot of labels, so make it a verbose info log + glog.V(9).Infof("unable to normalize group-resource %s from label %q, skipping: %v", groupRes.String(), lbl, err) continue }