pkg/naming/BuildExternal: respect namespace

Currently, the namespace is ignored for external labels.

This fixes it.
This commit is contained in:
Sergiusz Urbaniak 2019-05-17 15:01:35 +02:00
parent 4b695d4e06
commit 486324753e
No known key found for this signature in database
GPG key ID: 300137157DBED7EF

View file

@ -142,6 +142,19 @@ func (q *metricsQuery) BuildExternal(seriesName string, namespace string, groupB
// Build up the query parts from the selector.
queryParts = append(queryParts, q.createQueryPartsFromSelector(metricSelector)...)
if namespace != "" {
namespaceLbl, err := q.resConverter.LabelForResource(NsGroupResource)
if err != nil {
return "", err
}
queryParts = append(queryParts, queryPart{
labelName: string(namespaceLbl),
values: []string{namespace},
operator: selection.Equals,
})
}
// Convert our query parts into the types we need for our template.
exprs, valuesByName, err := q.processQueryParts(queryParts)