From 93974115ad501c7c245ea16e5252705d67136868 Mon Sep 17 00:00:00 2001 From: richardbrks Date: Fri, 28 Sep 2018 07:52:48 -0400 Subject: [PATCH 1/4] remove repeated word --- docs/config-walkthrough.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/config-walkthrough.md b/docs/config-walkthrough.md index e71ae1a5..e493a94d 100644 --- a/docs/config-walkthrough.md +++ b/docs/config-walkthrough.md @@ -2,7 +2,7 @@ Configuration Walkthroughs ========================== *If you're looking for reference documentation on configuration, please -read the the [configuration reference](/docs/config.md)* +read the [configuration reference](/docs/config.md)* Per-pod HTTP Requests --------------------- @@ -105,7 +105,7 @@ in the custom-metrics-apiserver boilerplate guide. Now, cumulative metrics (like those that end in `_total`) aren't particularly useful for autoscaling, so we want to convert them to rate metrics in the API. We'll call the rate version of our metric -`http_requests_per_second`. We can use the the `name` field to tell the +`http_requests_per_second`. We can use the `name` field to tell the adapter about that: ```yaml From b381aef37b68cfddd3f4295af5dcc8171c50f8fd Mon Sep 17 00:00:00 2001 From: richardbrks Date: Fri, 28 Sep 2018 07:54:52 -0400 Subject: [PATCH 2/4] correct file path --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b5e38786..5ef9c242 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ information. ### Why isn't my metric showing up? First, check your configuration. Does it select your metric? You can -find the [default configuration](/deploy/custom-metrics-config-map.yaml) +find the [default configuration](/deploy/manifests/custom-metrics-config-map.yaml) in the deploy directory, and more information about configuring the adapter in the [docs](/docs/config.md). From 8d12f4f5fd8a0abdf9df2382764d910ee1333019 Mon Sep 17 00:00:00 2001 From: richardbrks Date: Fri, 28 Sep 2018 12:40:07 -0400 Subject: [PATCH 3/4] correct capitalization --- docs/config-walkthrough.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/config-walkthrough.md b/docs/config-walkthrough.md index e493a94d..039ff0f7 100644 --- a/docs/config-walkthrough.md +++ b/docs/config-walkthrough.md @@ -34,7 +34,7 @@ http_requests_total{method="GET",kubernetes_namespace="production",kubernetes_po The adapter considers metrics in the following ways: -1. First, It discovers the metrics available (*Discovery*) +1. First, it discovers the metrics available (*Discovery*) 2. Then, it figures out which Kubernetes resources each metric is associated with (*Association*) From 94379a1780e61108929a155781172a8b468a2697 Mon Sep 17 00:00:00 2001 From: richardbrks Date: Fri, 28 Sep 2018 12:53:39 -0400 Subject: [PATCH 4/4] delete repeated phrase --- docs/config-walkthrough.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/config-walkthrough.md b/docs/config-walkthrough.md index 039ff0f7..fa720de9 100644 --- a/docs/config-walkthrough.md +++ b/docs/config-walkthrough.md @@ -58,7 +58,7 @@ rules: If we want to find all `http_requests_total` series ourselves in the Prometheus dashboard, we'd write `http_requests_total{kubernetes_namespace!="",kubernetes_pod_name!=""}` to -find all find all `http_requests_total` series that were associated with +find all `http_requests_total` series that were associated with a namespace and pod. We can add this to our rule in the `seriesQuery` field, to tell the