From 19504aadd8f9ae1d83983ff98e5a64589d4fac6e Mon Sep 17 00:00:00 2001
From: Antoine Viallon <antoine@lesviallon.fr>
Date: Sat, 16 Jul 2022 19:21:04 +0200
Subject: [PATCH] [Services] Fix print sharing

Opened a few ports, make CUPS listen on all IPv4 addresses.
Enable System Config Printer by default.
---
 services.nix | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/services.nix b/services.nix
index 8f9ba91..879f527 100644
--- a/services.nix
+++ b/services.nix
@@ -53,8 +53,10 @@ in {
       openFirewall = true;
     };
     
-    networking.firewall.allowedTCPPorts = [ 22 ];
-    networking.firewall.allowedUDPPorts = [ 22 ];
+    networking.firewall.allowedTCPPorts = [ 22 ]
+      ++ optionals config.services.printing.enable [ 631 139 445 ];
+    networking.firewall.allowedUDPPorts = [ 22 5353 ]
+      ++ optionals config.services.printing.enable [ 137 ];
 
     services.rsyncd.enable = !desktopCfg.enable;
 
@@ -68,6 +70,7 @@ in {
       enable = true;
       defaultShared = mkDefault true;
       browsing = mkDefault true;
+      listenAddresses = [ "0.0.0.0:631" ];
       drivers = with pkgs; [
         hplipWithPlugin
         gutenprint
@@ -92,6 +95,7 @@ in {
       ];
       webInterface = mkDefault true;
     };
+    services.system-config-printer.enable = mkIf desktopCfg.enable true;
 
     hardware.sane = mkIf desktopCfg.enable {
       enable = true;